-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set background for WCO container #35569
Conversation
Background of the container view should also be adjusted when user calls |
Added. |
f1882c4
to
ffbebbd
Compare
Failing test is unrelated, merging. |
Release Notes Persisted
|
I have automatically backported this PR to "19-x-y", please check out #35610 |
I have automatically backported this PR to "20-x-y", please check out #35611 |
I have automatically backported this PR to "21-x-y", please check out #35612 |
* fix: Set background for WCO container * Add background when invalidating as well
Description of Change
Fixes #35312
Ref #35312 (comment)
Chromium was setting a background colour for the windows control overlay container, whereas we weren't. This PR copies the line so that we are also setting a background colour for the WCO container, which should avoid rendering glitches.
I'm currently on an RTL system language to work on another issue, so the WCO in the demo below is mirrored, but it shows that the gaps have been filled in with the overlay button colour.
CC @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Added a background to the WCO container to avoid rendering glitches.